Re: [PATCH v2 1/6] completion: add comment for test_completion()

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 10:06 PM, Felipe Contreras wrote: > On Fri, Nov 16, 2012 at 9:54 PM, SZEDER Gábor wrote: >> On Sun, Nov 11, 2012 at 03:35:53PM +0100, Felipe Contreras wrote: >>> So that it's easier to understand what it does. >>> >>> Also, make sure we pass only the first argument for com

Re: [PATCH v2 1/6] completion: add comment for test_completion()

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 9:54 PM, SZEDER Gábor wrote: > On Sun, Nov 11, 2012 at 03:35:53PM +0100, Felipe Contreras wrote: >> So that it's easier to understand what it does. >> >> Also, make sure we pass only the first argument for completion. >> Shouldn't cause any functional changes because run_co

Re: [PATCH v2 1/6] completion: add comment for test_completion()

2012-11-16 Thread SZEDER Gábor
On Sun, Nov 11, 2012 at 03:35:53PM +0100, Felipe Contreras wrote: > So that it's easier to understand what it does. > > Also, make sure we pass only the first argument for completion. > Shouldn't cause any functional changes because run_completion only > checks $1. > > Signed-off-by: Felipe Contr

[PATCH v2 1/6] completion: add comment for test_completion()

2012-11-11 Thread Felipe Contreras
So that it's easier to understand what it does. Also, make sure we pass only the first argument for completion. Shouldn't cause any functional changes because run_completion only checks $1. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 6 +- 1 file changed, 5 insertions(+), 1