On Fri, 04 May 2018 11:24:39 +0900
Junio C Hamano wrote:
> Hmm, when somebody breaks "git server serve", we probably would not
> want to see the binary spewed to the output while debugging it. So
> I'd probably keep the redirection---it may be an improvement to use
> ">out" and then checking it
Jonathan Tan writes:
> On Thu, 3 May 2018 11:58:59 -0700
> Stefan Beller wrote:
>
>> > + test_must_fail git -C server serve --stateless-rpc /dev/null
>> > 2>err &&
>>
>> Minor nit:
>> Why do we pipe stdout to /dev/null ?
>
> Usually there's a binary packfile produced, but not in this cas
On Thu, 3 May 2018 11:58:59 -0700
Stefan Beller wrote:
> > + test_must_fail git -C server serve --stateless-rpc /dev/null
> > 2>err &&
>
> Minor nit:
> Why do we pipe stdout to /dev/null ?
Usually there's a binary packfile produced, but not in this case. I'll
remove it.
On Tue, May 1, 2018 at 5:31 PM, Jonathan Tan wrote:
> Fix a typo in an error message.
>
> Also, this line was introduced in 3145ea957d2c ("upload-pack: introduce
> fetch server command", 2018-03-15), which did not contain a test for the
> case which causes this error to be printed, so introduce a
Fix a typo in an error message.
Also, this line was introduced in 3145ea957d2c ("upload-pack: introduce
fetch server command", 2018-03-15), which did not contain a test for the
case which causes this error to be printed, so introduce a test.
Signed-off-by: Jonathan Tan
---
t/t5701-git-serve.sh
5 matches
Mail list logo
