Re: [PATCH v2 1/2] sha1_file: open window into packfiles with CLOEXEC

2016-10-25 Thread Junio C Hamano
Johannes Schindelin writes: > The patch series may be a little bit more pleasant to read if you renamed > git_open_noatime() to git_open() first, in a separate commit. Possibly. If this were "we added a new parameter at the same time and each calling site of the renamed function with an extra p

Re: [PATCH v2 1/2] sha1_file: open window into packfiles with CLOEXEC

2016-10-25 Thread Johannes Schindelin
Hi Lars, On Mon, 24 Oct 2016, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > All processes that the Git main process spawns inherit the open file > descriptors of the main process. These leaked file descriptors can > cause problems. > > Use the CLOEXEC flag similar to 05d1ed61 to f

[PATCH v2 1/2] sha1_file: open window into packfiles with CLOEXEC

2016-10-24 Thread larsxschneider
From: Lars Schneider All processes that the Git main process spawns inherit the open file descriptors of the main process. These leaked file descriptors can cause problems. Use the CLOEXEC flag similar to 05d1ed61 to fix the leaked file descriptors. Since `git_open_noatime` does not describe the