Re: [PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-29 Thread William Hubbs
On Fri, Jan 25, 2019 at 11:58:10PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Jan 25 2019, William Hubbs wrote: > > > @@ -480,6 +515,46 @@ int git_ident_config(const char *var, const char > > *value, void *data) > > return 0; > > } > > > > + if (!strcmp(var, "author.name

Re: [PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-28 Thread William Hubbs
On Mon, Jan 28, 2019 at 09:04:15PM +0100, Ævar Arnfjörð Bjarmason wrote: > > Adjusting for limited time, I'm happy to help out with this series, > particularly if you have visual (screen reader) issues that make some of > this prohibitive for you. Just say what you need. I guess the best way to h

Re: [PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-28 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > I'm happy to help if you'd like. I had a thinko with "table", and I > think our asciidoc dialect doesn't support it (maybe I'm wrong), but > thinking about it again we could just describe these variables all in > the same documentation. As in this hunk (which you

Re: [PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-28 Thread Ævar Arnfjörð Bjarmason
On Mon, Jan 28 2019, William Hubbs wrote: > On Fri, Jan 25, 2019 at 11:58:10PM +0100, Ævar Arnfjörð Bjarmason wrote: >> >> On Fri, Jan 25 2019, William Hubbs wrote: >> >> > diff --git a/Documentation/config/user.txt b/Documentation/config/user.txt >> > index b5b2ba1199..18e1ec3c1b 100644 >> > --

Re: [PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-28 Thread Junio C Hamano
William Hubbs writes: > This doesn't look like it is beyond 79 characters to me, but that may be > because I use a tab stop width of 4. In this project, a tab skips to multiple of 8.

Re: [PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-28 Thread William Hubbs
On Fri, Jan 25, 2019 at 11:58:10PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Jan 25 2019, William Hubbs wrote: > > > diff --git a/Documentation/config/user.txt b/Documentation/config/user.txt > > index b5b2ba1199..18e1ec3c1b 100644 > > --- a/Documentation/config/user.txt > > +++ b/Documen

Re: [PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-25 Thread Ævar Arnfjörð Bjarmason
On Fri, Jan 25 2019, William Hubbs wrote: > The author.email, author.name, committer.email and committer.name > settings are analogous to the GIT_AUTHOR_* and GIT_COMMITTER_* > environment variables, but for the git config system. This allows them > to be set separately for each repository. > >

[PATCH v2 1/2] config: allow giving separate author and committer idents

2019-01-25 Thread William Hubbs
The author.email, author.name, committer.email and committer.name settings are analogous to the GIT_AUTHOR_* and GIT_COMMITTER_* environment variables, but for the git config system. This allows them to be set separately for each repository. Git supports setting different authorship and committer