Re: [PATCH v2 1/1] reset: support the --stdin option

2017-01-27 Thread Junio C Hamano
Jeff King writes: > I think a lot of the documentation uses to refer to pathspecs > (e.g., git-log(1), git-diff(1), etc). As long as we're consistent with > that convention, I don't think it's that big a deal. > > This spot needs a specific mention because it violates the convention. Yup, I th

Re: [PATCH v2 1/1] reset: support the --stdin option

2017-01-27 Thread Jeff King
On Fri, Jan 27, 2017 at 10:30:48AM -0800, Junio C Hamano wrote: > > Is it worth clarifying that these are paths, not pathspecs? The word > > "paths" is used to refer to the pathspecs on the command-line elsewhere > > in the document. > > If the code forces literal pathspecs, then what the user fe

Re: [PATCH v2 1/1] reset: support the --stdin option

2017-01-27 Thread Junio C Hamano
Jeff King writes: > A few minor suggestions: > >> +--stdin:: >> +Instead of taking list of paths from the command line, >> +read list of paths from the standard input. Paths are >> +separated by LF (i.e. one path per line) by default. >> + >> +-z:: >> +Only meaningful with `--std

Re: [PATCH v2 1/1] reset: support the --stdin option

2017-01-27 Thread Jeff King
On Fri, Jan 27, 2017 at 06:34:46PM +0100, Johannes Schindelin wrote: > > Is it worth clarifying that these are paths, not pathspecs? The word > > "paths" is used to refer to the pathspecs on the command-line elsewhere > > in the document. > > > > It might also be worth mentioning the quoting rule

Re: [PATCH v2 1/1] reset: support the --stdin option

2017-01-27 Thread Johannes Schindelin
Hi Peff, On Fri, 27 Jan 2017, Jeff King wrote: > On Fri, Jan 27, 2017 at 01:38:55PM +0100, Johannes Schindelin wrote: > > A few minor suggestions: > > > +--stdin:: > > + Instead of taking list of paths from the command line, > > + read list of paths from the standard input. Paths are > > +

Re: [PATCH v2 1/1] reset: support the --stdin option

2017-01-27 Thread Jeff King
On Fri, Jan 27, 2017 at 01:38:55PM +0100, Johannes Schindelin wrote: > Just like with other Git commands, this option makes it read the paths > from the standard input. It comes in handy when resetting many, many > paths at once and wildcards are not an option (e.g. when the paths are > generated

[PATCH v2 1/1] reset: support the --stdin option

2017-01-27 Thread Johannes Schindelin
Just like with other Git commands, this option makes it read the paths from the standard input. It comes in handy when resetting many, many paths at once and wildcards are not an option (e.g. when the paths are generated by a tool). Note: we first parse the entire list and perform the actual reset