Re: [PATCH v2 1/1] protocol: advertise multiple supported versions

2018-10-22 Thread Stefan Beller
> > similar to argv_array_pushl or would that be overengineered? > Am I missing some other way to do this cleanly? I'll admit I'm not very > familiar with va_lists. Ah, you're right. By not passing pointers (and I am unfamiliar with va_lists, too), this was a moot suggestion. > > Yeah, my unders

Re: [PATCH v2 1/1] protocol: advertise multiple supported versions

2018-10-22 Thread Josh Steadmon
On 2018.10.12 15:30, Stefan Beller wrote: > On Thu, Oct 11, 2018 at 6:02 PM wrote: > > > > From: Josh Steadmon > > > > Currently the client advertises that it supports the wire protocol > > version set in the protocol.version config. However, not all services > > support the same set of protocol

Re: [PATCH v2 1/1] protocol: advertise multiple supported versions

2018-10-12 Thread Stefan Beller
On Thu, Oct 11, 2018 at 6:02 PM wrote: > > From: Josh Steadmon > > Currently the client advertises that it supports the wire protocol > version set in the protocol.version config. However, not all services > support the same set of protocol versions. When connecting to > git-receive-pack, the cli

[PATCH v2 1/1] protocol: advertise multiple supported versions

2018-10-11 Thread steadmon
From: Josh Steadmon Currently the client advertises that it supports the wire protocol version set in the protocol.version config. However, not all services support the same set of protocol versions. When connecting to git-receive-pack, the client automatically downgrades to v0 if config.protocol