Re: [PATCH v2 1/1] git-p4: auto-delete named temporary file

2019-10-05 Thread Junio C Hamano
> >> ... > >> Luke, does this look good? > >> > >> I know Mazo is the only other contributor who has multiple commits > >> to git-p4.py in the past 2 years, to make Reviewed-by carry some > >> weight ;-) but as we have so small number of people touching this > >> script anyway, I'd rather see

Re: [PATCH v2 1/1] git-p4: auto-delete named temporary file

2019-08-28 Thread Luke Diamand
On Tue, 27 Aug 2019 at 23:31, Junio C Hamano wrote: > > Andrey Mazo writes: > > > From: "Philip.McGraw" > > > > Avoid double-open exceptions on Windows platform when > > calculating for lfs compressed size threshold > > (git-p4.largeFileCompressedThreshold) comparisons. > > > > Take new approach

Re: [PATCH v2 1/1] git-p4: auto-delete named temporary file

2019-08-27 Thread Junio C Hamano
Andrey Mazo writes: > From: "Philip.McGraw" > > Avoid double-open exceptions on Windows platform when > calculating for lfs compressed size threshold > (git-p4.largeFileCompressedThreshold) comparisons. > > Take new approach using the NamedTemporaryFile() > file-like object as input to the ZipFi

[PATCH v2 1/1] git-p4: auto-delete named temporary file

2019-08-26 Thread Andrey Mazo
From: "Philip.McGraw" Avoid double-open exceptions on Windows platform when calculating for lfs compressed size threshold (git-p4.largeFileCompressedThreshold) comparisons. Take new approach using the NamedTemporaryFile() file-like object as input to the ZipFile() which auto-deletes after implic