Re: [PATCH v2 1/1] fsmonitor: don't fill bitmap with entries to be removed

2019-10-11 Thread William Baker
On 10/10/19 4:22 AM, SZEDER Gábor wrote: >>> +# This test covers staging/unstaging files that appear at the end of the >>> index. >>> +# Test files with names beginning with 'z' are used under the assumption >>> that >>> +# earlier tests do not add/leave index entries that sort below them. > >

Re: [PATCH v2 1/1] fsmonitor: don't fill bitmap with entries to be removed

2019-10-10 Thread SZEDER Gábor
On Thu, Oct 10, 2019 at 01:07:32PM +0200, SZEDER Gábor wrote: > On Wed, Oct 09, 2019 at 02:00:12PM -0700, William Baker via GitGitGadget > wrote: > > diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh > > index 81a375fa0f..87042470ab 100755 > > --- a/t/t7519-status-fsmonitor.sh

Re: [PATCH v2 1/1] fsmonitor: don't fill bitmap with entries to be removed

2019-10-10 Thread SZEDER Gábor
On Wed, Oct 09, 2019 at 02:00:12PM -0700, William Baker via GitGitGadget wrote: > diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh > index 81a375fa0f..87042470ab 100755 > --- a/t/t7519-status-fsmonitor.sh > +++ b/t/t7519-status-fsmonitor.sh > @@ -354,4 +354,17 @@ test_expect_s

[PATCH v2 1/1] fsmonitor: don't fill bitmap with entries to be removed

2019-10-09 Thread William Baker via GitGitGadget
From: William Baker While doing some testing with fsmonitor enabled I found that git commands would segfault after staging and unstaging an untracked file. Looking at the crash it appeared that fsmonitor_ewah_callback was attempting to adjust bits beyond the bounds of the index cache. Digging i