Re: [PATCH v2 1/1] doc: Change zsh git completion file name

2019-10-14 Thread Junio C Hamano
SZEDER Gábor writes: >> -# The recommended way to install this script is to copy to '~/.zsh/_git', >> and >> -# then add the following to your ~/.zshrc file: >> +# The recommended way to install this script is to make a copy of it in >> +# ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then

Re: [PATCH v2 1/1] doc: Change zsh git completion file name

2019-10-14 Thread SZEDER Gábor
On Fri, Oct 11, 2019 at 10:54:28AM -0700, Maxim Belsky via GitGitGadget wrote: > From: Maxim Belsky > > The original comment does not describe type of ~/.zsh/_git explicitly > and zsh does not warn or fail if a user create it as a dictionary. > So unexperienced users could be misled by the origin

Re: [PATCH v2 1/1] doc: Change zsh git completion file name

2019-10-11 Thread Junio C Hamano
"Maxim Belsky via GitGitGadget" writes: > Signed-off-by: Maxim Belsky > Helped-by: Johannes Schindelin > Helped-by: Junio C Hamano No need to resend (as I'll fix it up locally while queuing), but your sign-off comes last, as we keep these things chronological. With help from others, you wrote

[PATCH v2 1/1] doc: Change zsh git completion file name

2019-10-11 Thread Maxim Belsky via GitGitGadget
From: Maxim Belsky The original comment does not describe type of ~/.zsh/_git explicitly and zsh does not warn or fail if a user create it as a dictionary. So unexperienced users could be misled by the original comment. There is a small update to clarify it. Signed-off-by: Maxim Belsky Helped-