Re: [PATCH v2 09/14] range-diff: split lines manually

2019-07-08 Thread Thomas Gummerer
On 07/05, Johannes Schindelin wrote: > Hi Thomas, > > > On Fri, 5 Jul 2019, Thomas Gummerer wrote: > > > Currently range-diff uses the 'strbuf_getline()' function for doing > > its line by line processing. In a future patch we want to do parts of > > that parsing using the 'parse_git_header()'

Re: [PATCH v2 09/14] range-diff: split lines manually

2019-07-05 Thread Johannes Schindelin
Hi Thomas, On Fri, 5 Jul 2019, Thomas Gummerer wrote: > Currently range-diff uses the 'strbuf_getline()' function for doing > its line by line processing. In a future patch we want to do parts of > that parsing using the 'parse_git_header()' function, which does If you like my suggestion in pa

[PATCH v2 09/14] range-diff: split lines manually

2019-07-05 Thread Thomas Gummerer
Currently range-diff uses the 'strbuf_getline()' function for doing its line by line processing. In a future patch we want to do parts of that parsing using the 'parse_git_header()' function, which does requires reading parts of the input from that function, which doesn't use strbufs. Switch rang