Re: [PATCH v2 07/21] builtin/receive-pack: convert portions to struct object_id

On Wed, Mar 29, 2017 at 11:21:52PM +, brian m. carlson wrote: > On Tue, Mar 28, 2017 at 03:07:12AM -0400, Jeff King wrote: > > It took me a while to find it. This is the switch from "len == 48" to > > "len > 8" when matching "shallow" lines. I think this makes sense. > > > > > Note that in qu

Re: [PATCH v2 07/21] builtin/receive-pack: convert portions to struct object_id

On Tue, Mar 28, 2017 at 03:07:12AM -0400, Jeff King wrote: > It took me a while to find it. This is the switch from "len == 48" to > "len > 8" when matching "shallow" lines. I think this makes sense. > > > Note that in queue_command we are guaranteed to have a NUL-terminated > > buffer or at least

Re: [PATCH v2 07/21] builtin/receive-pack: convert portions to struct object_id

On Sun, Mar 26, 2017 at 04:01:29PM +, brian m. carlson wrote: > Convert some hardcoded constants into uses of parse_oid_hex. > Additionally, convert all uses of struct command, and miscellaneous > other functions necessary for that. This work is necessary to be able > to convert sha1_array_ap

[PATCH v2 07/21] builtin/receive-pack: convert portions to struct object_id

Convert some hardcoded constants into uses of parse_oid_hex. Additionally, convert all uses of struct command, and miscellaneous other functions necessary for that. This work is necessary to be able to convert sha1_array_append later on. To avoid needing to specify a constant, reject shallow line