Re: [PATCH v2 07/19] hashmap_get takes "const struct hashmap_entry *"

2019-09-30 Thread Eric Wong
Derrick Stolee wrote: > On 9/23/2019 9:03 PM, Eric Wong wrote: > > This is less error-prone than "const void *" as the compiler > > now detects invalid types being passed. > [snip] > > diff --git a/hashmap.h b/hashmap.h > > index 40bcc64289..2a4b4a3954 100644 > > --- a/hashmap.h > > +++ b/hashmap.

Re: [PATCH v2 07/19] hashmap_get takes "const struct hashmap_entry *"

2019-09-25 Thread Derrick Stolee
On 9/23/2019 9:03 PM, Eric Wong wrote: > This is less error-prone than "const void *" as the compiler > now detects invalid types being passed. [snip] > diff --git a/hashmap.h b/hashmap.h > index 40bcc64289..2a4b4a3954 100644 > --- a/hashmap.h > +++ b/hashmap.h > @@ -74,7 +74,8 @@ > *

[PATCH v2 07/19] hashmap_get takes "const struct hashmap_entry *"

2019-09-23 Thread Eric Wong
This is less error-prone than "const void *" as the compiler now detects invalid types being passed. Signed-off-by: Eric Wong --- attr.c| 2 +- blame.c | 6 +++--- builtin/difftool.c| 5 +++-- builtin/fast-export.c | 2 +- config.c | 2 +- diff.c