Re: [PATCH v2 07/14] apply: make parse_git_header public

2019-07-05 Thread Johannes Schindelin
Hi Thomas, On Fri, 5 Jul 2019, Thomas Gummerer wrote: > Make parse_git_header a "public" function in apply.h, so we can re-use > it in range-diff in a subsequent commit. This function probably wants a different name when it becomes public, as it was relatively obvious inside `apply.c` that it wa

[PATCH v2 07/14] apply: make parse_git_header public

2019-07-05 Thread Thomas Gummerer
Make parse_git_header a "public" function in apply.h, so we can re-use it in range-diff in a subsequent commit. Signed-off-by: Thomas Gummerer --- I considered creating a separate struct for only the metadata here, and embedding that in 'struct patch'. As struct patch is mostly metadata fields