Re: [PATCH v2 06/21] attr.c: use fopen_or_warn()

2017-05-03 Thread Johannes Schindelin
Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy As commented about warn_on_fopen_errors(), I do not see a benefit in separating the introduction of this small function from the individual files' changes to use it. Let's bring it all together. Ciao

[PATCH v2 06/21] attr.c: use fopen_or_warn()

2017-05-03 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- attr.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/attr.c b/attr.c index 7e2134471c..821203e2a9 100644 --- a/attr.c +++ b/attr.c @@ -720,16 +720,13 @@ void git_attr_set_direction(enum git_attr_direction new_direction, stat