Re: [PATCH v2 06/12] commit: add tests of commit races

2015-02-17 Thread Michael Haggerty
On 02/12/2015 08:36 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> diff --git a/t/t7516-commit-races.sh b/t/t7516-commit-races.sh >> new file mode 100755 >> index 000..08e6a6c >> --- /dev/null >> +++ b/t/t7516-commit-races.sh >> @@ -0,0 +1,33 @@ >> +#!/bin/sh >> + >> +test_descript

Re: [PATCH v2 06/12] commit: add tests of commit races

2015-02-17 Thread Michael Haggerty
On 02/12/2015 07:13 PM, Stefan Beller wrote: > On Thu, Feb 12, 2015 at 3:12 AM, Michael Haggerty > wrote: >> Committing involves the following steps: >> [...] >> diff --git a/t/t7516-commit-races.sh b/t/t7516-commit-races.sh >> new file mode 100755 >> index 000..08e6a6c >> --- /dev/null >> ++

Re: [PATCH v2 06/12] commit: add tests of commit races

2015-02-12 Thread Junio C Hamano
Michael Haggerty writes: > diff --git a/t/t7516-commit-races.sh b/t/t7516-commit-races.sh > new file mode 100755 > index 000..08e6a6c > --- /dev/null > +++ b/t/t7516-commit-races.sh > @@ -0,0 +1,33 @@ > +#!/bin/sh > + > +test_description='git commit races' > +. ./test-lib.sh > + > +test_tick

Re: [PATCH v2 06/12] commit: add tests of commit races

2015-02-12 Thread Stefan Beller
On Thu, Feb 12, 2015 at 3:12 AM, Michael Haggerty wrote: > Committing involves the following steps: > > 1. Determine the current value of HEAD (if any). > 2. Create the new commit object. > 3. Update HEAD. > > Please note that step 2 can take arbitrarily long, because it might > involve the user e

[PATCH v2 06/12] commit: add tests of commit races

2015-02-12 Thread Michael Haggerty
Committing involves the following steps: 1. Determine the current value of HEAD (if any). 2. Create the new commit object. 3. Update HEAD. Please note that step 2 can take arbitrarily long, because it might involve the user editing a commit message. If a second process sneaks in a commit during