Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-06 Thread Derrick Stolee
On 2/5/2018 1:48 PM, Junio C Hamano wrote: Jeff King writes: The big advantage of your scheme is that you can update the graph index without repacking. The traditional advice has been that you should always do a full repack during a gc (since it gives the most delta opportunities). So metadata

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-05 Thread Junio C Hamano
Jeff King writes: > The big advantage of your scheme is that you can update the graph index > without repacking. The traditional advice has been that you should > always do a full repack during a gc (since it gives the most delta > opportunities). So metadata like reachability bitmaps were happy

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-05 Thread Derrick Stolee
On 2/1/2018 6:48 PM, SZEDER Gábor wrote: Teach git-commit-graph to write graph files. Create new test script to verify this command succeeds without failure. Signed-off-by: Derrick Stolee --- Documentation/git-commit-graph.txt | 18 +++ builtin/commit-graph.c | 30 +++

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-03 Thread Jeff King
On Fri, Feb 02, 2018 at 08:58:52PM -0500, Derrick Stolee wrote: > I don't think pairing this with pack-objects or index-pack is a good > direction, because the commit graph is not locked into a packfile the way > the bitmap is. In fact, the entire ODB could be replaced independently and > the grap

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-02 Thread Derrick Stolee
On 2/2/2018 5:48 PM, Junio C Hamano wrote: Stefan Beller writes: It is true for git-submodule and a few others (the minority of commands IIRC) git-tag for example takes subcommands such as --list or --verify. https://public-inbox.org/git/xmqqiomodkt9@gitster.dls.corp.google.com/ Thanks.

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-02 Thread Junio C Hamano
Stefan Beller writes: > It is true for git-submodule and a few others (the minority of commands IIRC) > git-tag for example takes subcommands such as --list or --verify. > https://public-inbox.org/git/xmqqiomodkt9@gitster.dls.corp.google.com/ Thanks. It refers to an article at gmane, which

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-02 Thread Stefan Beller
On Thu, Feb 1, 2018 at 3:33 PM, Jonathan Tan wrote: > On Tue, 30 Jan 2018 16:39:34 -0500 > Derrick Stolee wrote: > >> diff --git a/Documentation/git-commit-graph.txt >> b/Documentation/git-commit-graph.txt >> index c8ea548dfb..3f3790d9a8 100644 >> --- a/Documentation/git-commit-graph.txt >> +++

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-01 Thread SZEDER Gábor
> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > new file mode 100755 > index 00..6bcd1cc264 > --- /dev/null > +++ b/t/t5318-commit-graph.sh > @@ -0,0 +1,96 @@ > +#!/bin/sh > + > +test_description='commit graph' > +. ./test-lib.sh > + > +test_expect_success 'setup full rep

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-01 Thread SZEDER Gábor
> Teach git-commit-graph to write graph files. Create new test script to verify > this command succeeds without failure. > > Signed-off-by: Derrick Stolee > --- > Documentation/git-commit-graph.txt | 18 +++ > builtin/commit-graph.c | 30 > t/t5318-commit-graph.sh

Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-02-01 Thread Jonathan Tan
On Tue, 30 Jan 2018 16:39:34 -0500 Derrick Stolee wrote: > diff --git a/Documentation/git-commit-graph.txt > b/Documentation/git-commit-graph.txt > index c8ea548dfb..3f3790d9a8 100644 > --- a/Documentation/git-commit-graph.txt > +++ b/Documentation/git-commit-graph.txt > @@ -5,3 +5,21 @@ NAME >

[PATCH v2 05/14] commit-graph: implement git-commit-graph --write

2018-01-30 Thread Derrick Stolee
Teach git-commit-graph to write graph files. Create new test script to verify this command succeeds without failure. Signed-off-by: Derrick Stolee --- Documentation/git-commit-graph.txt | 18 +++ builtin/commit-graph.c | 30 t/t5318-commit-graph.sh| 96 ++