Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-07-08 Thread Junio C Hamano
Duy Nguyen writes: > The command is to dump .git/index, not the shared one. And since this > is not a split index test, rather a (quite low-level) json dump test, > I did not bother to also dump the shared index, which should look like > a regular one. Producing a unified view in json might not b

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-07-04 Thread Duy Nguyen
On Fri, Jul 5, 2019 at 3:01 AM SZEDER Gábor wrote: > > On Mon, Jun 24, 2019 at 08:02:21PM +0700, Nguyễn Thái Ngọc Duy wrote: > > diff --git a/t/t3011-ls-files-json.sh b/t/t3011-ls-files-json.sh > > index 082fe8e966..dbb572ce9d 100755 > > --- a/t/t3011-ls-files-json.sh > > +++ b/t/t3011-ls-files-js

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-07-04 Thread SZEDER Gábor
On Mon, Jun 24, 2019 at 08:02:21PM +0700, Nguyễn Thái Ngọc Duy wrote: > diff --git a/t/t3011-ls-files-json.sh b/t/t3011-ls-files-json.sh > index 082fe8e966..dbb572ce9d 100755 > --- a/t/t3011-ls-files-json.sh > +++ b/t/t3011-ls-files-json.sh > @@ -44,4 +44,18 @@ test_expect_success 'ls-files --json,

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-07-03 Thread SZEDER Gábor
On Mon, Jun 24, 2019 at 08:02:21PM +0700, Nguyễn Thái Ngọc Duy wrote: > diff --git a/t/t3011-ls-files-json.sh b/t/t3011-ls-files-json.sh > index 082fe8e966..dbb572ce9d 100755 > --- a/t/t3011-ls-files-json.sh > +++ b/t/t3011-ls-files-json.sh > @@ -44,4 +44,18 @@ test_expect_success 'ls-files --json,

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-27 Thread Duy Nguyen
On Thu, Jun 27, 2019 at 8:42 PM Derrick Stolee wrote: > > On 6/27/2019 9:24 AM, Jeff Hostetler wrote: > > On 6/27/2019 6:48 AM, Duy Nguyen wrote: > >> On Tue, Jun 25, 2019 at 7:40 PM Derrick Stolee wrote: > >>> > >>> On 6/25/2019 6:29 AM, Duy Nguyen wrote: > On Tue, Jun 25, 2019 at 3:06 AM J

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-27 Thread Derrick Stolee
On 6/27/2019 9:24 AM, Jeff Hostetler wrote: > On 6/27/2019 6:48 AM, Duy Nguyen wrote: >> On Tue, Jun 25, 2019 at 7:40 PM Derrick Stolee wrote: >>> >>> On 6/25/2019 6:29 AM, Duy Nguyen wrote: On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler wrote: > I'm curious how big these EWAHs wil

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-27 Thread Jeff Hostetler
On 6/27/2019 6:48 AM, Duy Nguyen wrote: On Tue, Jun 25, 2019 at 7:40 PM Derrick Stolee wrote: On 6/25/2019 6:29 AM, Duy Nguyen wrote: On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler wrote: I'm curious how big these EWAHs will be in practice and how useful an array of integers will be (esp

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-27 Thread Duy Nguyen
On Tue, Jun 25, 2019 at 7:40 PM Derrick Stolee wrote: > > On 6/25/2019 6:29 AM, Duy Nguyen wrote: > > On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler > > wrote: > >> I'm curious how big these EWAHs will be in practice and > >> how useful an array of integers will be (especially as the > >> pretty

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-25 Thread Derrick Stolee
On 6/25/2019 6:29 AM, Duy Nguyen wrote: > On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler wrote: >> I'm curious how big these EWAHs will be in practice and >> how useful an array of integers will be (especially as the >> pretty format will be one integer per line). Perhaps it >> would helpful to h

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-25 Thread Duy Nguyen
On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler wrote: > I'm curious how big these EWAHs will be in practice and > how useful an array of integers will be (especially as the > pretty format will be one integer per line). Perhaps it > would helpful to have an extended example in one of the > tests.

Re: [PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-24 Thread Jeff Hostetler
On 6/24/2019 9:02 AM, Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy --- json-writer.c | 14 ++ json-writer.h | 3 +++ split-index.c | 9 - t/t3011-ls-files-json.sh | 14 ++ t/t3011/split-index (new)

[PATCH v2 05/10] split-index.c: dump "link" extension as json

2019-06-24 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- json-writer.c | 14 ++ json-writer.h | 3 +++ split-index.c | 9 - t/t3011-ls-files-json.sh | 14 ++ t/t3011/split-index (new) | 39 +++ 5 files chang