Re: [PATCH v2 04/34] sequencer (rebase -i): implement the 'exec' command

2016-12-19 Thread Johannes Schindelin
Hi Junio, On Tue, 13 Dec 2016, Junio C Hamano wrote: > Please have "else if" on the same line as "}" that closes the > "if (...) {" in the same if/else if/else cascade. Fixed. This affected quite a few more patches than just this one, and added two more to this already large patch series. Ciao,

Re: [PATCH v2 04/34] sequencer (rebase -i): implement the 'exec' command

2016-12-13 Thread Junio C Hamano
Johannes Schindelin writes: > +static int do_exec(const char *command_line) > +{ > + const char *child_argv[] = { NULL, NULL }; > + int dirty, status; > + > + fprintf(stderr, "Executing: %s\n", command_line); > + child_argv[0] = command_line; > + status = run_command_v_opt(chi

[PATCH v2 04/34] sequencer (rebase -i): implement the 'exec' command

2016-12-13 Thread Johannes Schindelin
The 'exec' command is a little special among rebase -i's commands, as it does *not* have a SHA-1 as first parameter. Instead, everything after the `exec` command is treated as command-line to execute. Let's reuse the arg/arg_len fields of the todo_item structure (which hold the oneline for pick/ed