Re: [PATCH v2 04/21] wrapper.c: add warn_on_fopen_errors()

2017-05-03 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > dir.c | 3 +-- > git-compat-util.h | 2 ++ > wrapper.c | 10 ++ > 3 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/dir.c b/dir.c > index f451bfa48c..8218a24962 100644 > --

Re: [PATCH v2 04/21] wrapper.c: add warn_on_fopen_errors()

2017-05-03 Thread Johannes Schindelin
Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy This commit message is a bit empty. How about: In many places, Git warns about an inaccessible file after a fopen() failed. To discern these cases from other cases where we wan

[PATCH v2 04/21] wrapper.c: add warn_on_fopen_errors()

2017-05-03 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- dir.c | 3 +-- git-compat-util.h | 2 ++ wrapper.c | 10 ++ 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/dir.c b/dir.c index f451bfa48c..8218a24962 100644 --- a/dir.c +++ b/dir.c @@ -745,8 +745,7 @@ static in