Re: [PATCH v2 04/12] ref_transaction_update(): remove "have_old" parameter

2015-02-13 Thread Junio C Hamano
Michael Haggerty writes: > On 02/12/2015 06:32 PM, Junio C Hamano wrote: >> On Thu, Feb 12, 2015 at 3:12 AM, Michael Haggerty >> wrote: >>> Instead, verify the reference's old value if and only if old_sha1 is >>> non-NULL. >>> >>> ... >>> @@ -3664,9 +3664,6 @@ int ref_transaction_update(struct

Re: [PATCH v2 04/12] ref_transaction_update(): remove "have_old" parameter

2015-02-13 Thread Michael Haggerty
On 02/12/2015 06:32 PM, Junio C Hamano wrote: > On Thu, Feb 12, 2015 at 3:12 AM, Michael Haggerty > wrote: >> Instead, verify the reference's old value if and only if old_sha1 is >> non-NULL. >> >> ... >> @@ -3664,9 +3664,6 @@ int ref_transaction_update(struct ref_transaction >> *transaction, >>

Re: [PATCH v2 04/12] ref_transaction_update(): remove "have_old" parameter

2015-02-12 Thread Junio C Hamano
On Thu, Feb 12, 2015 at 3:12 AM, Michael Haggerty wrote: > Instead, verify the reference's old value if and only if old_sha1 is > non-NULL. > >... > @@ -3664,9 +3664,6 @@ int ref_transaction_update(struct ref_transaction > *transaction, > if (transaction->state != REF_TRANSACTION_OPEN) >

[PATCH v2 04/12] ref_transaction_update(): remove "have_old" parameter

2015-02-12 Thread Michael Haggerty
Instead, verify the reference's old value if and only if old_sha1 is non-NULL. ref_transaction_delete() will get the same treatment in a moment. Signed-off-by: Michael Haggerty Reviewed-by: Stefan Beller --- branch.c | 5 +++-- builtin/commit.c | 2 +- builtin/fetch.c