Re: [PATCH v2 03/34] sequencer (rebase -i): implement the 'edit' command

2016-12-19 Thread Junio C Hamano
Johannes Schindelin writes: >> > + strbuf_addf(&buf, "%s/patch", get_dir(opts)); >> > + memset(&log_tree_opt, 0, sizeof(log_tree_opt)); >> > + init_revisions(&log_tree_opt, NULL); >> > + log_tree_opt.abbrev = 0; >> > + log_tree_opt.diff = 1; >> > + log_tree_opt.diffopt.output_format = DIFF_

Re: [PATCH v2 03/34] sequencer (rebase -i): implement the 'edit' command

2016-12-19 Thread Junio C Hamano

Re: [PATCH v2 03/34] sequencer (rebase -i): implement the 'edit' command

2016-12-19 Thread Johannes Schindelin
Hi Junio, On Tue, 13 Dec 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > @@ -43,6 +44,20 @@ static GIT_PATH_FUNC(rebase_path_todo, > > "rebase-merge/git-rebase-todo") > > */ > > static GIT_PATH_FUNC(rebase_path_author_script, > > "rebase-merge/author-script") > > /* > > I

Re: [PATCH v2 03/34] sequencer (rebase -i): implement the 'edit' command

2016-12-13 Thread Junio C Hamano
Johannes Schindelin writes: > @@ -43,6 +44,20 @@ static GIT_PATH_FUNC(rebase_path_todo, > "rebase-merge/git-rebase-todo") > */ > static GIT_PATH_FUNC(rebase_path_author_script, "rebase-merge/author-script") > /* It is minor, but please have a blank line to separate the logical blocks. If y

[PATCH v2 03/34] sequencer (rebase -i): implement the 'edit' command

2016-12-13 Thread Johannes Schindelin
This patch is a straight-forward reimplementation of the `edit` operation of the interactive rebase command. Well, not *quite* straight-forward: when stopping, the `edit` command wants to write the `patch` file (which is not only the patch, but includes the commit message and author information).