Re: [PATCH v2 03/25] transport-helper.c: do not send null option to remote helper

Duy Nguyen writes: > On Fri, Feb 5, 2016 at 6:22 AM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> Signed-off-by: Nguyễn Thái Ngọc Duy >>> --- >> >> This is even more strange. Are the current callers broken and some >> sends value==NULL for an option that is not is_bool, resul

Re: [PATCH v2 03/25] transport-helper.c: do not send null option to remote helper

On Fri, Feb 5, 2016 at 6:22 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- > > This is even more strange. Are the current callers broken and some > sends value==NULL for an option that is not is_bool, resulting in > a call to quote_c_st

Re: [PATCH v2 03/25] transport-helper.c: do not send null option to remote helper

Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- This is even more strange. Are the current callers broken and some sends value==NULL for an option that is not is_bool, resulting in a call to quote_c_style() with NULL? I somehow find it hard to believe as that would l

[PATCH v2 03/25] transport-helper.c: do not send null option to remote helper

Signed-off-by: Nguyễn Thái Ngọc Duy --- transport-helper.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/transport-helper.c b/transport-helper.c index 35023da..2e78c4d 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -309,8 +309,12 @@ static int set_helper_op