Re: [PATCH v2 02/34] sequencer (rebase -i): implement the 'noop' command

Johannes Schindelin writes: > On Tue, 13 Dec 2016, Junio C Hamano wrote: > >> Linus Torvalds writes: >> >> > On Tue, Dec 13, 2016 at 12:38 PM, Junio C Hamano wrote: >> >> Johannes Schindelin writes: >> >> >> >>> +/* >> >>> + * Note that ordering matters in this enum. Not only must it match th

Re: [PATCH v2 02/34] sequencer (rebase -i): implement the 'noop' command

Hi Junio, On Tue, 13 Dec 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > @@ -1292,7 +1316,12 @@ static int pick_commits(struct todo_list *todo_list, > > struct replay_opts *opts) > > struct todo_item *item = todo_list->items + todo_list->current; > > if

Re: [PATCH v2 02/34] sequencer (rebase -i): implement the 'noop' command

Hi, On Tue, 13 Dec 2016, Junio C Hamano wrote: > Linus Torvalds writes: > > > On Tue, Dec 13, 2016 at 12:38 PM, Junio C Hamano wrote: > >> Johannes Schindelin writes: > >> > >>> +/* > >>> + * Note that ordering matters in this enum. Not only must it match the > >>> mapping > >>> + * below, i

Re: [PATCH v2 02/34] sequencer (rebase -i): implement the 'noop' command

Linus Torvalds writes: > On Tue, Dec 13, 2016 at 12:38 PM, Junio C Hamano wrote: >> Johannes Schindelin writes: >> >>> +/* >>> + * Note that ordering matters in this enum. Not only must it match the >>> mapping >>> + * below, it is also divided into several sections that matter. When >>> add

Re: [PATCH v2 02/34] sequencer (rebase -i): implement the 'noop' command

On Tue, Dec 13, 2016 at 12:38 PM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> +/* >> + * Note that ordering matters in this enum. Not only must it match the >> mapping >> + * below, it is also divided into several sections that matter. When adding >> + * new commands, make sure you

Re: [PATCH v2 02/34] sequencer (rebase -i): implement the 'noop' command

Johannes Schindelin writes: > +/* > + * Note that ordering matters in this enum. Not only must it match the > mapping > + * below, it is also divided into several sections that matter. When adding > + * new commands, make sure you add it in the right section. > + */ Good thinking. Makes me wi

[PATCH v2 02/34] sequencer (rebase -i): implement the 'noop' command

The 'noop' command is probably the most boring of all rebase -i commands to support in the sequencer. Which makes it an excellent candidate for this first stab to add support for rebase -i's commands to the sequencer. For the moment, let's also treat empty lines and commented-out lines as 'noop';