Re: [PATCH v2 02/25] isxdigit: cast input to unsigned char

Jeff King writes: > Otherwise, callers must do so or risk triggering warnings > -Wchar-subscript (and rightfully so; a signed char might > cause us to use a bogus negative index into the > hexval_table). > > While we are dropping the now-unnecessary casts from the > caller in urlmatch.c, we can g

[PATCH v2 02/25] isxdigit: cast input to unsigned char

Otherwise, callers must do so or risk triggering warnings -Wchar-subscript (and rightfully so; a signed char might cause us to use a bogus negative index into the hexval_table). While we are dropping the now-unnecessary casts from the caller in urlmatch.c, we can get rid of similar casts in actual