Re: [PATCH v2 02/19] parse-options-cb: implement parse_opt_pass_argv_array()

Paul Tan writes: > I don't see how it feels iffy. That is largely a taste thing. And a good taste matters. What is iffy is to use strbuf as an external interface between the implementation of the parse_opt_pass() API function and its users. I would expect that no users of the parse_opt_pass()

Re: [PATCH v2 02/19] parse-options-cb: implement parse_opt_pass_argv_array()

On Wed, Jun 10, 2015 at 7:16 AM, Junio C Hamano wrote: > Almost the same comment as 01/19 applies to this comment. > > I think it makes good sense to have two variants, one that lets the > last one win and pass only that last one (i.e. 01/19) and the other > that accumulates them into an argv_arra

Re: [PATCH v2 02/19] parse-options-cb: implement parse_opt_pass_argv_array()

Paul Tan writes: > Certain git commands, such as git-pull, are simply wrappers around other > git commands like git-fetch, git-merge and git-rebase. As such, these > wrapper commands will typically need to "pass through" command-line > options of the commands they wrap. > > Implement the parse_op

Re: [PATCH v2 02/19] parse-options-cb: implement parse_opt_pass_argv_array()

On Tue, Jun 2, 2015 at 11:48 PM, Paul Tan wrote: > Certain git commands, such as git-pull, are simply wrappers around other > git commands like git-fetch, git-merge and git-rebase. As such, these > wrapper commands will typically need to "pass through" command-line > options of the commands they w

[PATCH v2 02/19] parse-options-cb: implement parse_opt_pass_argv_array()

Certain git commands, such as git-pull, are simply wrappers around other git commands like git-fetch, git-merge and git-rebase. As such, these wrapper commands will typically need to "pass through" command-line options of the commands they wrap. Implement the parse_opt_pass_argv_array() parse-opti