[PATCH v2 02/10] Define utility functions for object IDs.

2015-03-13 Thread brian m. carlson
There are several utility functions (hashcmp and friends) that are used for comparing object IDs (SHA-1 values). Using these functions, which take pointers to unsigned char, with struct object_id requires tiresome access to the sha1 member, which bloats code and violates the desired encapsulation.

Re: [PATCH v2 02/10] Define utility functions for object IDs.

2015-03-11 Thread Michael Haggerty
On 03/08/2015 12:23 AM, brian m. carlson wrote: > There are several utility functions (hashcmp and friends) that are used > for comparing object IDs (SHA-1 values). Using these functions, which > take pointers to unsigned char, with struct object_id requires tiresome > access to the sha1 member, w

Re: [PATCH v2 02/10] Define utility functions for object IDs.

2015-03-08 Thread brian m. carlson
On Sun, Mar 08, 2015 at 04:57:36PM +0700, Duy Nguyen wrote: On Sun, Mar 8, 2015 at 6:23 AM, brian m. carlson wrote: I'm not very excited about having to put the #include in the middle of cache.h. The alternative, of course, is to move enum object_type up, which I can do if necessary. Another

Re: [PATCH v2 02/10] Define utility functions for object IDs.

2015-03-08 Thread Duy Nguyen
On Sun, Mar 8, 2015 at 6:23 AM, brian m. carlson wrote: > There are several utility functions (hashcmp and friends) that are used > for comparing object IDs (SHA-1 values). Using these functions, which > take pointers to unsigned char, with struct object_id requires tiresome > access to the sha1

[PATCH v2 02/10] Define utility functions for object IDs.

2015-03-07 Thread brian m. carlson
There are several utility functions (hashcmp and friends) that are used for comparing object IDs (SHA-1 values). Using these functions, which take pointers to unsigned char, with struct object_id requires tiresome access to the sha1 member, which bloats code and violates the desired encapsulation.