Re: [PATCH v2 01/21] path.c: avoid PATH_MAX as buffer size from get_pathname()

2013-12-15 Thread Antoine Pelisse
On Sun, Dec 15, 2013 at 10:02 AM, Duy Nguyen wrote: > On Sun, Dec 15, 2013 at 3:35 PM, Torsten Bögershausen wrote: >> If we really want to go away from PATH_MAX, is a hard-coded value of 4096 so >> attractive ? >> Because we can either >> >> a) Re-define PATH_MAX in git-compat-util.h >> b) Use a

Re: [PATCH v2 01/21] path.c: avoid PATH_MAX as buffer size from get_pathname()

2013-12-15 Thread Duy Nguyen
On Sun, Dec 15, 2013 at 3:35 PM, Torsten Bögershausen wrote: > If we really want to go away from PATH_MAX, is a hard-coded value of 4096 so > attractive ? > Because we can either > > a) Re-define PATH_MAX in git-compat-util.h > b) Use an own #define in git-compat-util.h, like e.g. GIT_PATH_MAX >

Re: [PATCH v2 01/21] path.c: avoid PATH_MAX as buffer size from get_pathname()

2013-12-15 Thread Torsten Bögershausen
On 2013-12-14 11.54, Nguyễn Thái Ngọc Duy wrote: > We've been avoiding PATH_MAX whenever possible. This patch avoids > PATH_MAX in get_pathname() and gives it enough room not to worry about > really long paths. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > path.c | 28 -

[PATCH v2 01/21] path.c: avoid PATH_MAX as buffer size from get_pathname()

2013-12-14 Thread Nguyễn Thái Ngọc Duy
We've been avoiding PATH_MAX whenever possible. This patch avoids PATH_MAX in get_pathname() and gives it enough room not to worry about really long paths. Signed-off-by: Nguyễn Thái Ngọc Duy --- path.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --