Re: [PATCH v2 01/15] t7408: replace `test_must_fail test_path_is_file`

2019-10-19 Thread Johannes Sixt
Am 19.10.19 um 00:04 schrieb Denton Liu: > diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh > index 34ac28c056..9e62d43cac 100755 > --- a/t/t7408-submodule-reference.sh > +++ b/t/t7408-submodule-reference.sh > @@ -123,7 +123,7 @@ test_expect_success 'missing submodule al

[PATCH v2 01/15] t7408: replace `test_must_fail test_path_is_file`

2019-10-18 Thread Denton Liu
According to t/README, test_must_fail() should only be used to test for failure in git commands. Replace the only invocation of `test_must_fail test_path_is_file` with `test_path_is_missing` since in this test case, the path should not exist at all. Signed-off-by: Denton Liu --- t/t7408-submodul