Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-09 Thread Jeff King
On Wed, Apr 10, 2019 at 12:08:45AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote: > > > >> > /* global flag to enable extra checks when accessing packed objects */ > >> > -extern int do_check_packed_object_crc; > >> > +int do

Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-09 Thread Junio C Hamano
Jeff King writes: > On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote: > >> > /* global flag to enable extra checks when accessing packed objects */ >> > -extern int do_check_packed_object_crc; >> > +int do_check_packed_object_crc; >> >> ... removing this 'extern' on an int variable

Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-08 Thread Jeff King
On Mon, Apr 08, 2019 at 02:13:17PM +0900, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote: > > > >> > /* global flag to enable extra checks when accessing packed objects */ > >> > -extern int do_check_packed_object_crc; > >> > +int do

Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-07 Thread Junio C Hamano
Jeff King writes: > On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote: > >> > /* global flag to enable extra checks when accessing packed objects */ >> > -extern int do_check_packed_object_crc; >> > +int do_check_packed_object_crc; >> >> ... removing this 'extern' on an int variable

Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-05 Thread Jeff King
On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote: > > /* global flag to enable extra checks when accessing packed objects */ > > -extern int do_check_packed_object_crc; > > +int do_check_packed_object_crc; > > ... removing this 'extern' on an int variable sends 'sparse' > into a fren

Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-05 Thread Ramsay Jones
On 05/04/2019 19:03, Jeff King wrote: > As CodingGuidelines recommends, we do not need an "extern" when > declaring a public function. Let's drop these. Note that we leave the > extern on report_garbage(), as that is actually a function pointer, not > a function itself. Hmm, perhaps we need to

[PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-05 Thread Jeff King
As CodingGuidelines recommends, we do not need an "extern" when declaring a public function. Let's drop these. Note that we leave the extern on report_garbage(), as that is actually a function pointer, not a function itself. Signed-off-by: Jeff King --- This is bumped to the front in v2 since we