Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-27 Thread Junio C Hamano
Duy Nguyen writes: > On Sat, Mar 23, 2013 at 10:13 AM, Duy Nguyen wrote: >> which also includes all document bugs reported so far. > > s/all/fixes for all/ Slurped from your github repository and didn't find anything questionable relative to the original series that was posted here. Thanks. W

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-23 Thread Eric Sunshine
On Fri, Mar 22, 2013 at 11:13 PM, Duy Nguyen wrote: > diff --git a/setup.c b/setup.c > index e59146b..6cf2bc6 100644 > --- a/setup.c > +++ b/setup.c > @@ -5,24 +5,37 @@ > static int inside_git_dir = -1; > static int inside_work_tree = -1; > > -char *prefix_path_gently(const char *prefix, int *p_

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-22 Thread Duy Nguyen
On Sat, Mar 23, 2013 at 10:13 AM, Duy Nguyen wrote: > which also includes all document bugs reported so far. s/all/fixes for all/ -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-22 Thread Duy Nguyen
On Thu, Mar 21, 2013 at 10:50:02AM -0700, Junio C Hamano wrote: > > Why could the test pass for you without it? It doesn't look like a > > bug that depended on uninitialized memory or something from the > > above observation. It depends on uninitialized memory. For absolute paths, prefix is usele

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-21 Thread Junio C Hamano
Junio C Hamano writes: > Duy Nguyen writes: > >>> I still can't reproduce it. But I think I found a bug that >>> miscalculates prefix length from absolute paths. Does this "fix" your >>> test? >>> ... >> Nope, that one could cause more crashes. Try this >> >> -- 8< -- >> diff --git a/setup.c b/

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-21 Thread Junio C Hamano
Duy Nguyen writes: >> I still can't reproduce it. But I think I found a bug that >> miscalculates prefix length from absolute paths. Does this "fix" your >> test? >> ... > Nope, that one could cause more crashes. Try this > > -- 8< -- > diff --git a/setup.c b/setup.c > index 3584f22..3d8eb97 100

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-20 Thread Duy Nguyen
On Thu, Mar 21, 2013 at 12:33:26PM +0700, Duy Nguyen wrote: > > I am still getting this out of 7300, though. > > I still can't reproduce it. But I think I found a bug that > miscalculates prefix length from absolute paths. Does this "fix" your > test? > > -- 8< -- > diff --git a/setup.c b/setup.c

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-20 Thread Duy Nguyen
On Wed, Mar 20, 2013 at 11:02:50AM -0700, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > > > Junio please pull the series from github [1] > > [1] https://github.com/pclouds/git/commits/parse-pathspec > > Please write it like this: > > https://github.com/pclouds/git parse-pathsp

Re: [PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-20 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Junio please pull the series from github [1] > [1] https://github.com/pclouds/git/commits/parse-pathspec Please write it like this: https://github.com/pclouds/git parse-pathspec so that I can just say git fetch <> git diff nd/magic-paths

[PATCH v2 00/45] parse_pathspec and :(glob) magic

2013-03-20 Thread Nguyễn Thái Ngọc Duy
Junio please pull the series from github [1]. I don't want to spam the list with 45 patches again so I only send patches that are substantially different from v1: - documentation for parse_pathspec - fix wrong operator precendence in git-reset - fix initialization that may lead to crashes in gi