Re: [PATCH v2 0/9] icase match on non-ascii

2015-07-08 Thread Duy Nguyen
On Wed, Jul 8, 2015 at 10:36 PM, Junio C Hamano wrote: >> Patch 5 is "funny". The patch itself is in iso-8859-1, but my name in >> the commit message is in utf-8. > > As an e-mail message is a single file, by definition that is not merely > "funny" but just "broken", no matter what encoding your M

Re: [PATCH v2 0/9] icase match on non-ascii

2015-07-08 Thread Junio C Hamano
> Patch 5 is "funny". The patch itself is in iso-8859-1, but my name in > the commit message is in utf-8. As an e-mail message is a single file, by definition that is not merely "funny" but just "broken", no matter what encoding your MUA declares the contents are in, no? -- To unsubscribe from thi

Re: [PATCH v2 0/9] icase match on non-ascii

2015-07-08 Thread Duy Nguyen
On Wed, Jul 8, 2015 at 6:32 PM, Torsten Bögershausen wrote: > On 2015-07-08 12.38, Nguyễn Thái Ngọc Duy wrote: >> Side note, I almost added the third has_non_ascii() function. Maybe we >> should consider merging the two existing has_non_ascii() functions >> back, or rename one to something else. >

Re: [PATCH v2 0/9] icase match on non-ascii

2015-07-08 Thread Torsten Bögershausen
On 2015-07-08 12.38, Nguyễn Thái Ngọc Duy wrote: > Side note, I almost added the third has_non_ascii() function. Maybe we > should consider merging the two existing has_non_ascii() functions > back, or rename one to something else. > Side question: has_non_ascii can mean different things: UTF-8,

[PATCH v2 0/9] icase match on non-ascii

2015-07-08 Thread Nguyễn Thái Ngọc Duy
This series fix case insensitive matching on non-ascii charsets. "grep -i", "grep -F -i", "grep --pcre-regexp -i" and "log -i -S" are fixed. Side note, I almost added the third has_non_ascii() function. Maybe we should consider merging the two existing has_non_ascii() functions back, or rename one