Re: [PATCH v2 0/8] Avoid problem where git_dir is set after alias expansion

2017-06-08 Thread Brandon Williams
On 06/08, Johannes Schindelin wrote: > > Changes since v1: > > - 1/8's commit message clarifies why the other early return in > discover_git_directory() does not need an equivalent resetting of > git_dir. > > - 3/8's commit message fixes awkward language (thanks, Brandon!). > > - the `workt

[PATCH v2 0/8] Avoid problem where git_dir is set after alias expansion

2017-06-08 Thread Johannes Schindelin
When expanding an alias in a subdirectory, we setup the git_dir (gently), read the config, and then restore the "env" (e.g. the current working directory) so that the command specified by the alias can run correctly. What we failed to reset was the git_dir, meaning that in the most common case, it