Re: [PATCH v2 0/6] Teach '--column-number' to 'git-grep(1)'

2018-04-23 Thread Junio C Hamano
Taylor Blau writes: >> It seems that these two used to be "even when it is configured not >> to show linenumber, with -n it is shown and without -n it is not, >> when the new --column-number feature forces the command to show the >> "filename plus colon plus location info plus coon" header. I'm

Re: [PATCH v2 0/6] Teach '--column-number' to 'git-grep(1)'

2018-04-22 Thread Taylor Blau
On Mon, Apr 23, 2018 at 08:28:14AM +0900, Junio C Hamano wrote: > Taylor Blau writes: > > > diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh > > index 0cf654824d..7349c7fadc 100755 > > --- a/t/t7810-grep.sh > > +++ b/t/t7810-grep.sh > > @@ -106,7 +106,7 @@ do > > echo ${HC}file:5

Re: [PATCH v2 0/6] Teach '--column-number' to 'git-grep(1)'

2018-04-22 Thread Junio C Hamano
Taylor Blau writes: > * Removed '-m' as an alias for '--column-number', per René's > suggestion [1]. > > * Fix some incorrect spelling of 'columnnumber'. > > * Change casing of 'color.grep.linenumber' to 'color.grep.lineNumber' > to be consistent with 'color.grep.columnNumber'. This

[PATCH v2 0/6] Teach '--column-number' to 'git-grep(1)'

2018-04-22 Thread Taylor Blau
Hi, Attached is a re-roll of the series to add --column-number to 'git-grep(1)'. Since last time, I have changed the following (an inter-diff is available below for easier consumption): * Removed '-m' as an alias for '--column-number', per René's suggestion [1]. * Fix some incorrect spe