Re: [PATCH v2 0/5] New hash table implementation

2013-09-26 Thread Karsten Blees
Am 24.09.2013 13:16, schrieb Tay Ray Chuan: > Hi Karsten, > > On Tue, Sep 24, 2013 at 5:50 PM, Karsten Blees > wrote: >> >> | add| get 100% hits |get 10% hits >> | hash | hashmap | hash | hashmap | hash | hashmap >> ++-+---+--

Re: [PATCH v2 0/5] New hash table implementation

2013-09-26 Thread Karsten Blees
Am 26.09.2013 12:16, schrieb Fredrik Gustafsson: > On Tue, Sep 24, 2013 at 11:50:16AM +0200, Karsten Blees wrote: >> Tests can be reproduced with 'time echo "perfhash[map] 1000" | >> ./test-hashmap', see test-hashmap.c for definition of method flags. > > So I'm still curious about the actual per

Re: [PATCH v2 0/5] New hash table implementation

2013-09-26 Thread Duy Nguyen
On Thu, Sep 26, 2013 at 6:08 PM, Fredrik Gustafsson wrote: > On Thu, Sep 26, 2013 at 05:26:27PM +0700, Duy Nguyen wrote: >> On Thu, Sep 26, 2013 at 5:16 PM, Fredrik Gustafsson wrote: >> > On Tue, Sep 24, 2013 at 11:50:16AM +0200, Karsten Blees wrote: >> >> Tests can be reproduced with 'time echo

Re: [PATCH v2 0/5] New hash table implementation

2013-09-26 Thread Fredrik Gustafsson
On Thu, Sep 26, 2013 at 05:26:27PM +0700, Duy Nguyen wrote: > On Thu, Sep 26, 2013 at 5:16 PM, Fredrik Gustafsson wrote: > > On Tue, Sep 24, 2013 at 11:50:16AM +0200, Karsten Blees wrote: > >> Tests can be reproduced with 'time echo "perfhash[map] 1000" | > >> ./test-hashmap', see test-hashmap.c

Re: [PATCH v2 0/5] New hash table implementation

2013-09-26 Thread Duy Nguyen
On Thu, Sep 26, 2013 at 5:16 PM, Fredrik Gustafsson wrote: > On Tue, Sep 24, 2013 at 11:50:16AM +0200, Karsten Blees wrote: >> Tests can be reproduced with 'time echo "perfhash[map] 1000" | >> ./test-hashmap', see test-hashmap.c for definition of method flags. > > So I'm still curious about the

Re: [PATCH v2 0/5] New hash table implementation

2013-09-26 Thread Fredrik Gustafsson
On Tue, Sep 24, 2013 at 11:50:16AM +0200, Karsten Blees wrote: > Tests can be reproduced with 'time echo "perfhash[map] 1000" | > ./test-hashmap', see test-hashmap.c for definition of method flags. So I'm still curious about the actual performance improvements for git. I runned git describe on t

Re: [PATCH v2 0/5] New hash table implementation

2013-09-24 Thread Tay Ray Chuan
Hi Karsten, On Tue, Sep 24, 2013 at 5:50 PM, Karsten Blees wrote: > > | add| get 100% hits |get 10% hits > | hash | hashmap | hash | hashmap | hash | hashmap > ++-+---+-+-+ > FNV | 14.815 | 2.345 |

Re: [PATCH v2 0/5] New hash table implementation

2013-09-24 Thread Fredrik Gustafsson
On Tue, Sep 24, 2013 at 11:50:16AM +0200, Karsten Blees wrote: > Regarding performance, I have to admit that the difference between the two > implementations is far greater than I had anticipated. The following times > (in seconds) are from Linux x64 (Debian Sarge) on a Core i7 860 @2.8GHz. All

[PATCH v2 0/5] New hash table implementation

2013-09-24 Thread Karsten Blees
Also here: https://github.com/kblees/git/tree/kb/hashmap-v2 Changes since initial version: - removed struct typedefs - clarified documentation of hashmap_entry - renamed find_entry -> find_entry_ptr - added performance tests for lookup I've also tried to resize the table based on the number of u