Re: [PATCH v2 0/4] stripspace: Implement and use --count-lines option

On 2015-10-16 at 18:41:31 +0200, Junio C Hamano wrote: > Tobias Klauser writes: > > Be consistent with the subjects, please. > > > strbuf: make stripspace() part of strbuf > > s/make/make/ ;-) > > > stripspace: Use parse-options for command-line parsing > > s/Use/use/ > > > stripspace

Re: [PATCH v2 0/4] stripspace: Implement and use --count-lines option

On 2015-10-16 at 18:54:45 +0200, Matthieu Moy wrote: > Tobias Klauser writes: > > > - Split patch 2/3 into two patches: patch 2/4 switches git stripspace > > to use parse-options and patch 3/4 introduces the new option. > > Much better now. > > > - Implement line counting in cmd_strip

Re: [PATCH v2 0/4] stripspace: Implement and use --count-lines option

Tobias Klauser writes: > - Split patch 2/3 into two patches: patch 2/4 switches git stripspace > to use parse-options and patch 3/4 introduces the new option. Much better now. > - Implement line counting in cmd_stripbuf() instead of (ab-)using > strbuf_stripspace() for it. Also sho

Re: [PATCH v2 0/4] stripspace: Implement and use --count-lines option

Tobias Klauser writes: Be consistent with the subjects, please. > strbuf: make stripspace() part of strbuf s/make/make/ ;-) > stripspace: Use parse-options for command-line parsing s/Use/use/ > stripspace: Implement --count-lines option s/Implement/implement/ > git rebase -i: Use n

[PATCH v2 0/4] stripspace: Implement and use --count-lines option

(1) Move the stripspace() function to the strbuf module adding a prefix and changing all users accordingly. Also introduce a wrapper in case any topic branches still depend on the old name. (2) Switch git stripspace to use parse-options in order to simplify introducing new command line