Jeff King writes:
> The outer git wrapper doesn't start the pager, so its stderr still gets
> seen by the user. But the _inner_ git-log does start the pager, and then
> dies of SIGPIPE.
>
> So yeah, I think we want something like this on top of
> nd/clear-gitenv-upon-use-of-alias.
That makes sen
On Thu, Dec 24, 2015 at 04:35:33PM +0700, Duy Nguyen wrote:
> On Thu, Dec 24, 2015 at 4:31 AM, Jeff King wrote:
> > 2. I doubt anybody is actually seeing this in practice anymore. But
> > maybe I am misunderstanding something in Duy's series that changes
> > this.
>
> There are two p
On Thu, Dec 24, 2015 at 4:31 AM, Jeff King wrote:
> 2. I doubt anybody is actually seeing this in practice anymore. But
> maybe I am misunderstanding something in Duy's series that changes
> this.
There are two parts in your patch, one (that you two seemed to focus
on) about return co
On Wed, Dec 23, 2015 at 09:37:04PM +0100, Johannes Sixt wrote:
> >--- a/git.c
> >+++ b/git.c
> >@@ -252,7 +252,7 @@ static int handle_alias(int *argcp, const char ***argv)
> > alias_argv[argc] = NULL;
> >
> > ret = run_command_v_opt(alias_argv, RUN_USING_SHE
Am 23.12.2015 um 10:37 schrieb Jeff King:
The second line comes from handle_alias itself. It calls
die_errno whenever run_command returns a negative value.
However, only -1 indicates a syscall error where errno has
something useful (note that it says the useless "success"
above). Instead, we trea
On Wed, Dec 23, 2015 at 4:37 AM, Jeff King wrote:
> Subject: [PATCH] avoid SIGPIPE warnings for aliases
>
> When git executes an alias that specifies an external
> command, it will complain if the alias dies due to a signal.
> This is usually a good thing, as signal deaths are
> unexpected. Howeve
On Wed, Dec 23, 2015 at 4:37 PM, Jeff King wrote:
> On Tue, Dec 22, 2015 at 10:13:03AM -0800, Junio C Hamano wrote:
>
>> > Another by the way, this "forcing aliases as external commands" now
>> > shows something like "error: git-log died of signal 13" when the pager
>> > exits early, for an alias
On Tue, Dec 22, 2015 at 10:13:03AM -0800, Junio C Hamano wrote:
> > Another by the way, this "forcing aliases as external commands" now
> > shows something like "error: git-log died of signal 13" when the pager
> > exits early, for an alias like "l1 = log --oneline".
>
> ... and we do not show th
Duy Nguyen writes:
> On Tue, Dec 22, 2015 at 5:57 PM, Duy Nguyen wrote:
>> On Tue, Dec 22, 2015 at 4:18 AM, Junio C Hamano wrote:
>>> Thanks. I wiggled these three on top of the "Revert the earlier
>>> one"; while I think the result is correct, I'd appreciate if you can
>>> double check the re
On Tue, Dec 22, 2015 at 5:57 PM, Duy Nguyen wrote:
> On Tue, Dec 22, 2015 at 4:18 AM, Junio C Hamano wrote:
>> Thanks. I wiggled these three on top of the "Revert the earlier
>> one"; while I think the result is correct, I'd appreciate if you can
>> double check the result when I push the topic
On Tue, Dec 22, 2015 at 4:18 AM, Junio C Hamano wrote:
> Thanks. I wiggled these three on top of the "Revert the earlier
> one"; while I think the result is correct, I'd appreciate if you can
> double check the result when I push the topic out later today.
Looks good. "prove" passed too by the w
Thanks. I wiggled these three on top of the "Revert the earlier
one"; while I think the result is correct, I'd appreciate if you can
double check the result when I push the topic out later today.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord.
Changes since v1:
- make sure we save/restore env for external commands in 2/3
- fix t0001 test in 3/3
Interdiff:
diff --git b/git.c a/git.c
index 83b6c56..da278c3 100644
--- b/git.c
+++ a/git.c
@@ -229,7 +229,6 @@ static int handle_options(const char ***argv, int *argc,
int *envchanged)
sta
13 matches
Mail list logo
