Re: [PATCH v2 0/3] improve symbolic-ref robustness

2015-12-29 Thread Jeff King
On Tue, Dec 29, 2015 at 01:24:42PM -0800, Junio C Hamano wrote: > > The patches are: > > > > [1/3]: create_symref: modernize variable names > > [2/3]: create_symref: use existing ref-lock code > > [3/3]: create_symref: write reflog while holding lock > > This is queued as an early part of '

Re: [PATCH v2 0/3] improve symbolic-ref robustness

2015-12-29 Thread Junio C Hamano
Jeff King writes: > On Sun, Dec 20, 2015 at 02:26:37AM -0500, Jeff King wrote: > >> I noticed that an interrupt "git symbolic-ref" will not clean up >> "HEAD.lock". So I started this series as an attempt to convert >> create_symref() to "struct lock_file" to get the usual tempfile cleanup. > > He

Re: [PATCH v2 0/3] improve symbolic-ref robustness

2015-12-29 Thread Junio C Hamano
Michael Haggerty writes: > On 12/29/2015 06:55 AM, Jeff King wrote: > >> The patches are: >> >> [1/3]: create_symref: modernize variable names >> [2/3]: create_symref: use existing ref-lock code >> [3/3]: create_symref: write reflog while holding lock > > Thanks, Peff. The whole series is

Re: [PATCH v2 0/3] improve symbolic-ref robustness

2015-12-29 Thread Michael Haggerty
On 12/29/2015 06:55 AM, Jeff King wrote: > On Sun, Dec 20, 2015 at 02:26:37AM -0500, Jeff King wrote: > >> I noticed that an interrupt "git symbolic-ref" will not clean up >> "HEAD.lock". So I started this series as an attempt to convert >> create_symref() to "struct lock_file" to get the usual te

[PATCH v2 0/3] improve symbolic-ref robustness

2015-12-28 Thread Jeff King
On Sun, Dec 20, 2015 at 02:26:37AM -0500, Jeff King wrote: > I noticed that an interrupt "git symbolic-ref" will not clean up > "HEAD.lock". So I started this series as an attempt to convert > create_symref() to "struct lock_file" to get the usual tempfile cleanup. Here's version 2, based on comm