Re: [PATCH v2] worktree: add --quiet option

2018-08-16 Thread Junio C Hamano
Junio C Hamano writes: > Elia Pinto writes: > >> diff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh >> index be6e09314..658647d83 100755 >> --- a/t/t2025-worktree-add.sh >> +++ b/t/t2025-worktree-add.sh >> @@ -252,6 +252,11 @@ test_expect_success 'add -B' ' >> test_cmp_rev maste

Re: [PATCH v2] worktree: add --quiet option

2018-08-16 Thread Junio C Hamano
Elia Pinto writes: > diff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh > index be6e09314..658647d83 100755 > --- a/t/t2025-worktree-add.sh > +++ b/t/t2025-worktree-add.sh > @@ -252,6 +252,11 @@ test_expect_success 'add -B' ' > test_cmp_rev master^ poodle > ' > > +test_expect

Re: [PATCH v2] worktree: add --quiet option

2018-08-16 Thread Martin Ågren
Hi Eric, On Thu, 16 Aug 2018 at 10:25, Eric Sunshine wrote: > (/me nudges Martin off the fence onto the side of not bothering to > mention the obvious) :-) Thanks for sanity-checking my thoughts. I agree with everything you wrote in your reply (and, FWIW, your other findings that you sent separ

Re: [PATCH v2] worktree: add --quiet option

2018-08-16 Thread Eric Sunshine
On Wed, Aug 15, 2018 at 4:56 PM Elia Pinto wrote: > Add the '--quiet' option to git worktree, > as for the other git commands. 'add' is the > only command affected by it since all other > commands, except 'list', are currently > silent by default. Nit: wrap the commit message at around 70 columns

Re: [PATCH v2] worktree: add --quiet option

2018-08-16 Thread Eric Sunshine
On Thu, Aug 16, 2018 at 12:41 AM Martin Ågren wrote: > On Wed, 15 Aug 2018 at 22:56, Elia Pinto wrote: > The word "currently" means I can't shake the feeling that Eric has a > very good point in [1]: > > It might make sense to say instead that this is adding a --quiet > option _in general_, r

Re: [PATCH v2] worktree: add --quiet option

2018-08-15 Thread Martin Ågren
On Wed, 15 Aug 2018 at 22:56, Elia Pinto wrote: > Add the '--quiet' option to git worktree, > as for the other git commands. 'add' is the > only command affected by it since all other > commands, except 'list', are currently > silent by default. Thanks for a follow-up. The word "currently" means

Re: [PATCH v2] worktree: add --quiet option

2018-08-15 Thread Thomas Gummerer
On 08/15, Elia Pinto wrote: > Add the '--quiet' option to git worktree, > as for the other git commands. 'add' is the > only command affected by it since all other > commands, except 'list', are currently > silent by default. > > Helped-by: Martin Ågren > Helped-by: Duy Nguyen > Helped-by: Eric

[PATCH v2] worktree: add --quiet option

2018-08-15 Thread Elia Pinto
Add the '--quiet' option to git worktree, as for the other git commands. 'add' is the only command affected by it since all other commands, except 'list', are currently silent by default. Helped-by: Martin Ågren Helped-by: Duy Nguyen Helped-by: Eric Sunshine Signed-off-by: Elia Pinto --- This