Adrien Schildknecht writes:
> Add regexp based on the "Shell Command Language" specifications.
> Because of the lax syntax of sh, some corner cases may not be
> handled properly.
>
> Signed-off-by: Adrien Schildknecht
> ---
Is a reroll for this patch coming, or should I drop this from my
tree f
On overall, the patch looks good. Some suggestions to improve the tests
and a minor nitpick below.
Adrien Schildknecht writes:
> +++ b/t/t4034/sh/post
> @@ -0,0 +1,36 @@
> +foo() {ls&echo}
This part is unchanged here and in the pre file. What does it test?
> +$((x++))
> +$((x--))
> +$((--x))
>
Adrien Schildknecht writes:
> Add regexp based on the "Shell Command Language" specifications.
> Because of the lax syntax of sh, some corner cases may not be
> handled properly.
>
> Signed-off-by: Adrien Schildknecht
> ---
Those of you who helped in the first round of review, any comments,
"Th
Add regexp based on the "Shell Command Language" specifications.
Because of the lax syntax of sh, some corner cases may not be
handled properly.
Signed-off-by: Adrien Schildknecht
---
Documentation/gitattributes.txt | 2 ++
t/t4018-diff-funcname.sh| 1 +
t/t4018/sh-function
4 matches
Mail list logo
