Re: [PATCH v2] userdiff: Fix some corner cases in dts regex

2019-10-20 Thread Stephen Boyd
Quoting Johannes Sixt (2019-10-16 14:10:09) > [Removed bouncing addresses of Matthieu Moy and William Duclot from Cc] > > Am 16.10.19 um 22:32 schrieb Stephen Boyd: > > diff --git a/t/t4018/dts-nodes-multiline-prop > > b/t/t4018/dts-nodes-multiline-prop > > new file mode 100644 > > index

Re: [PATCH v2] userdiff: Fix some corner cases in dts regex

2019-10-16 Thread Johannes Sixt
[Removed bouncing addresses of Matthieu Moy and William Duclot from Cc] Am 16.10.19 um 22:32 schrieb Stephen Boyd: > diff --git a/t/t4018/dts-nodes-multiline-prop > b/t/t4018/dts-nodes-multiline-prop > new file mode 100644 > index ..db4b4bdda686 > --- /dev/null > +++ b/t/t4018/dts-nod

[PATCH v2] userdiff: Fix some corner cases in dts regex

2019-10-16 Thread Stephen Boyd
While reviewing some dts diffs recently I noticed that the hunk header logic was failing to find the containing node. This is because the regex doesn't consider properties that may span multiple lines, i.e. property = , ; and it got hung up on comments inside nodes that