Re: [PATCH v2] unpack-trees: don't update files with CE_WT_REMOVE set

2015-07-21 Thread Junio C Hamano
Junio C Hamano writes: > Duy Nguyen writes: > >> Thank you both for catching this. Just a small suggestion. Perhaps we >> should do this instead. apply_sparse_checkout() is the function where >> all "action" manipulation (add, delete, update files..) for sparse >> checkout occurs and it should n

Re: [PATCH v2] unpack-trees: don't update files with CE_WT_REMOVE set

2015-07-20 Thread David Turner
Anatole tells me that this works for us. Thanks. On Sat, 2015-07-18 at 15:37 +0700, Duy Nguyen wrote: > On Fri, Jul 17, 2015 at 05:19:27PM -0400, David Turner wrote: > > Don't update files in the worktree from cache entries which are > > flagged with CE_WT_REMOVE. > > > > When a user does a spar

Re: [PATCH v2] unpack-trees: don't update files with CE_WT_REMOVE set

2015-07-18 Thread Junio C Hamano
Duy Nguyen writes: > Thank you both for catching this. Just a small suggestion. Perhaps we > should do this instead. apply_sparse_checkout() is the function where > all "action" manipulation (add, delete, update files..) for sparse > checkout occurs and it should not ask to delete and update both

Re: [PATCH v2] unpack-trees: don't update files with CE_WT_REMOVE set

2015-07-18 Thread Duy Nguyen
On Fri, Jul 17, 2015 at 05:19:27PM -0400, David Turner wrote: > Don't update files in the worktree from cache entries which are > flagged with CE_WT_REMOVE. > > When a user does a sparse checkout, git removes files that are marked > with CE_WT_REMOVE (because they are out-of-scope for the sparse >

Re: [PATCH v2] unpack-trees: don't update files with CE_WT_REMOVE set

2015-07-17 Thread Junio C Hamano
David Turner writes: > Don't update files in the worktree from cache entries which are > flagged with CE_WT_REMOVE. > > When a user does a sparse checkout, git removes files that are marked > with CE_WT_REMOVE (because they are out-of-scope for the sparse > checkout). If those files are also mark

[PATCH v2] unpack-trees: don't update files with CE_WT_REMOVE set

2015-07-17 Thread David Turner
Don't update files in the worktree from cache entries which are flagged with CE_WT_REMOVE. When a user does a sparse checkout, git removes files that are marked with CE_WT_REMOVE (because they are out-of-scope for the sparse checkout). If those files are also marked CE_UPDATE (for instance, becaus