Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-04 Thread Junio C Hamano
Carlo Arenas writes: > v2 works fine, as expected Thanks.

Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-04 Thread Carlo Arenas
v2 works fine, as expected Carlo

Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-04 Thread SZEDER Gábor
On Fri, Jan 04, 2019 at 03:25:57AM -0800, Junio C Hamano wrote: > SZEDER Gábor writes: > > > On Thu, Jan 03, 2019 at 12:29:35PM -0800, Junio C Hamano wrote: > >> Let's treat this as an independent and more urgent fix-up. I think > >> it is sufficient to apply it to 2.20.x track, even though we c

Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-04 Thread Junio C Hamano
SZEDER Gábor writes: > On Thu, Jan 03, 2019 at 12:29:35PM -0800, Junio C Hamano wrote: >> Let's treat this as an independent and more urgent fix-up. I think >> it is sufficient to apply it to 2.20.x track, even though we could >> go back to 2.17.x and above. >> >> And then let's tentatively kic

Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-04 Thread SZEDER Gábor
On Thu, Jan 03, 2019 at 12:29:35PM -0800, Junio C Hamano wrote: > Let's treat this as an independent and more urgent fix-up. I think > it is sufficient to apply it to 2.20.x track, even though we could > go back to 2.17.x and above. > > And then let's tentatively kick the "stress test" series out

Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-03 Thread Junio C Hamano
SZEDER Gábor writes: > One of our test scripts, 't1510-repo-setup.sh' [1], still can't be > reliably run with '-x' tracing enabled, unless it's executed with a > Bash version supporting BASH_XTRACEFD (since v4.1). We have a lengthy > condition to check the version of the shell running the test s

[PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-03 Thread SZEDER Gábor
One of our test scripts, 't1510-repo-setup.sh' [1], still can't be reliably run with '-x' tracing enabled, unless it's executed with a Bash version supporting BASH_XTRACEFD (since v4.1). We have a lengthy condition to check the version of the shell running the test script, and disable tracing if i