Re: [PATCH v2] t0021: make sure clean filter runs

2019-08-23 Thread SZEDER Gábor
On Thu, Aug 22, 2019 at 08:22:40PM +0100, Thomas Gummerer wrote: > v2 adds the comment as suggested by Szeder. > + # Make sure that the file appears dirty, so checkout below has > to > + # run the configured filter. Yeah, but that comment only really applied when setting

Re: [PATCH v2] t0021: make sure clean filter runs

2019-08-22 Thread Junio C Hamano
Thomas Gummerer writes: > Fix the test by updating the mtime of test.r, so git is forced to > check the contents of the file, and the clean filter is run as the > test expects. > > Signed-off-by: Thomas Gummerer > --- > > v2 adds the comment as suggested by Szeder. > > Junio: I saw this is marke

[PATCH v2] t0021: make sure clean filter runs

2019-08-22 Thread Thomas Gummerer
In t0021.15 one of the things we are checking is that the clean filter is run when checking out empty-branch. The clean filter needs to be run to make sure there are no modifications on the file system for the test.r file, and thus it isn't dangerous to overwrite it. However in the current test s