Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-22 Thread 林自均
Hi Junio, 林自均 於 2019年5月15日 週三 上午11:02寫道: > > Hi Junio, > > Junio C Hamano 於 2019年5月15日 週三 上午8:48寫道: > > > > 林自均 writes: > > > > > I was not talking about the messages in the editor session. I was > > > talking about "git commit" without "git add" anything. > > > > > > For example: > > > > > > `

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-14 Thread 林自均
Hi Junio, Junio C Hamano 於 2019年5月15日 週三 上午8:48寫道: > > 林自均 writes: > > > I was not talking about the messages in the editor session. I was > > talking about "git commit" without "git add" anything. > > > > For example: > > > > ``` > > $ touch newfile.txt > > $ git commit > > On branch master > >

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-14 Thread Junio C Hamano
林自均 writes: > I was not talking about the messages in the editor session. I was > talking about "git commit" without "git add" anything. > > For example: > > ``` > $ touch newfile.txt > $ git commit > On branch master > Untracked files: > newfile.txt > > nothing added to commit but untrac

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-14 Thread 林自均
Hi Junio, Junio C Hamano 於 2019年5月14日 週二 下午3:33寫道: > > "brian m. carlson" writes: > > > On Mon, May 13, 2019 at 02:51:37PM +0900, Junio C Hamano wrote: > >> If the difference between "status" and "commit" bothers you so much, > >> i.e. > >> > >> When typing "git status", there is an empty li

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-14 Thread Junio C Hamano
"brian m. carlson" writes: > On Mon, May 13, 2019 at 02:51:37PM +0900, Junio C Hamano wrote: >> If the difference between "status" and "commit" bothers you so much, >> i.e. >> >> When typing "git status", there is an empty line between the >> "Changes not staged for commit:" block and th

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-13 Thread brian m. carlson
On Mon, May 13, 2019 at 02:51:37PM +0900, Junio C Hamano wrote: > If the difference between "status" and "commit" bothers you so much, > i.e. > > When typing "git status", there is an empty line between the > "Changes not staged for commit:" block and the list of changed > files. Howev

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-13 Thread 林自均
Hi Junio, Junio C Hamano 於 2019年5月13日 週一 下午1:51寫道: > > 林自均 writes: > > > Hi Junio, > >> ... > > Could you please give me some advice on my patch? Thank you. > > I tend to agree with what Phillip said in > . > > If the difference between "status" and "commit" bothers you so much, > i.e. > > W

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-12 Thread Junio C Hamano
林自均 writes: > Hi Junio, >> ... > Could you please give me some advice on my patch? Thank you. I tend to agree with what Phillip said in . If the difference between "status" and "commit" bothers you so much, i.e. When typing "git status", there is an empty line between the "Changes not

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-09 Thread 林自均
Hi Junio, 林自均 於 2019年5月3日 週五 下午12:15寫道: > > Hi Brian, > > brian m. carlson 於 2019年5月3日 週五 上午7:15寫道: > > > > On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote: > > > Thank you for the support! I'll be very happy if my patch can get into > > > the code base. Is there any improvement I can make f

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-02 Thread 林自均
Hi Brian, brian m. carlson 於 2019年5月3日 週五 上午7:15寫道: > > On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote: > > Thank you for the support! I'll be very happy if my patch can get into > > the code base. Is there any improvement I can make for this patch? > > The patch seems sane to me. There's le

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-02 Thread brian m. carlson
On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote: > Thank you for the support! I'll be very happy if my patch can get into > the code base. Is there any improvement I can make for this patch? The patch seems sane to me. There's less duplicate code than the patch I started writing; the goto conc

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-01 Thread 林自均
Hi Brian, brian m. carlson 於 2019年5月2日 週四 上午7:45寫道: > > On Tue, Apr 30, 2019 at 12:15:37PM +0100, Phillip Wood wrote: > > Hi John > > > > On 30/04/2019 07:02, John Lin wrote: > > > When typing "git status", there is an empty line between > > > the "Changes not staged for commit:" block and the li

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-01 Thread brian m. carlson
On Tue, Apr 30, 2019 at 12:15:37PM +0100, Phillip Wood wrote: > Hi John > > On 30/04/2019 07:02, John Lin wrote: > > When typing "git status", there is an empty line between > > the "Changes not staged for commit:" block and the list > > of changed files. > > I'm a bit confused by this as you cha

Re: [PATCH v2] status: add an empty line when there is no hint

2019-04-30 Thread 林自均
Hi Phillip, Phillip Wood 於 2019年4月30日 週二 下午7:15寫道: > > Hi John > > On 30/04/2019 07:02, John Lin wrote: > > When typing "git status", there is an empty line between > > the "Changes not staged for commit:" block and the list > > of changed files. > > I'm a bit confused by this as you change a sta

Re: [PATCH v2] status: add an empty line when there is no hint

2019-04-30 Thread Phillip Wood
Hi John On 30/04/2019 07:02, John Lin wrote: When typing "git status", there is an empty line between the "Changes not staged for commit:" block and the list of changed files. I'm a bit confused by this as you change a status test below by inserting these blank lines into the expected output,

[PATCH v2] status: add an empty line when there is no hint

2019-04-29 Thread John Lin
When typing "git status", there is an empty line between the "Changes not staged for commit:" block and the list of changed files. However, when typing "git commit" with no files added, there are no empty lines between them. This patch adds empty lines in the above case and some similar cases. Si