Re: [PATCH v2] stash: prefer --quiet over shell redirection

2014-09-13 Thread David Aguilar
On Fri, Sep 12, 2014 at 12:05:48PM -0700, Junio C Hamano wrote: > David Aguilar writes: > > > Use `git rev-parse --verify --quiet` instead of redirecting > > stderr to /dev/null. > > > > Signed-off-by: David Aguilar > > --- > > Has this patch ever been tested? t3903 seems to break with this at

Re: [PATCH v2] stash: prefer --quiet over shell redirection

2014-09-12 Thread Junio C Hamano
David Aguilar writes: > Use `git rev-parse --verify --quiet` instead of redirecting > stderr to /dev/null. > > Signed-off-by: David Aguilar > --- Has this patch ever been tested? t3903 seems to break with this at least for me. > git-stash.sh | 13 +++-- > 1 file changed, 7 insertions

[PATCH v2] stash: prefer --quiet over shell redirection

2014-08-31 Thread David Aguilar
Use `git rev-parse --verify --quiet` instead of redirecting stderr to /dev/null. Signed-off-by: David Aguilar --- git-stash.sh | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/git-stash.sh b/git-stash.sh index bcc757b..2ff8b94 100755 --- a/git-stash.sh +++ b/git-