Re: [PATCH v2] revision.c: fix possible null pointer access

2015-12-07 Thread Johannes Sixt
Am 07.12.2015 um 21:31 schrieb Junio C Hamano: Stefan Naewe writes: mark_tree_uninteresting dereferences a tree pointer before checking if the pointer is valid. Fix that by doing the check first. Signed-off-by: Stefan Naewe --- I still have a problem with "dereferences", as "dereference" i

Re: [PATCH v2] revision.c: fix possible null pointer access

2015-12-07 Thread Junio C Hamano
Stefan Naewe writes: > mark_tree_uninteresting dereferences a tree pointer before checking > if the pointer is valid. Fix that by doing the check first. > > Signed-off-by: Stefan Naewe > --- I still have a problem with "dereferences", as "dereference" is about computing an address and accessing

[PATCH v2] revision.c: fix possible null pointer access

2015-12-05 Thread Stefan Naewe
mark_tree_uninteresting dereferences a tree pointer before checking if the pointer is valid. Fix that by doing the check first. Signed-off-by: Stefan Naewe --- revision.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/revision.c b/revision.c index 0fbb684..8c569cc 100644