Re: [PATCH v2] repack: Add option to preserve and prune old pack files

2017-03-13 Thread Martin Fick
On Sunday, March 12, 2017 11:03:44 AM Junio C Hamano wrote: > Jeff King writes: > > I can think of one downside of a time-based solution, > > though: if you run multiple gc's during the time > > period, you may end up using a lot of disk space (one > > repo's worth per gc). But that's a fundamenta

Re: [PATCH v2] repack: Add option to preserve and prune old pack files

2017-03-12 Thread Junio C Hamano
Jeff King writes: > I can think of one downside of a time-based solution, though: if you run > multiple gc's during the time period, you may end up using a lot of disk > space (one repo's worth per gc). But that's a fundamental tension in the > problem space; the whole point is to waste disk to k

Re: [PATCH v2] repack: Add option to preserve and prune old pack files

2017-03-12 Thread Jeff King
On Fri, Mar 10, 2017 at 03:43:43PM -0800, Junio C Hamano wrote: > James Melvin writes: > > > The new --preserve-and-prune option renames old pack files > > instead of deleting them after repacking and prunes previously > > preserved pack files. > > > > This option is designed to prevent stale fi

Re: [PATCH v2] repack: Add option to preserve and prune old pack files

2017-03-11 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 10, 2017 at 11:00 PM, James Melvin wrote: > The new --preserve-and-prune option renames old pack files > instead of deleting them after repacking and prunes previously > preserved pack files. I think some of this rationale... > This option is designed to prevent stale file handle exc

Re: [PATCH v2] repack: Add option to preserve and prune old pack files

2017-03-10 Thread Junio C Hamano
James Melvin writes: > The new --preserve-and-prune option renames old pack files > instead of deleting them after repacking and prunes previously > preserved pack files. > > This option is designed to prevent stale file handle exceptions > during git operations which can happen on users of NFS r

[PATCH v2] repack: Add option to preserve and prune old pack files

2017-03-10 Thread James Melvin
The new --preserve-and-prune option renames old pack files instead of deleting them after repacking and prunes previously preserved pack files. This option is designed to prevent stale file handle exceptions during git operations which can happen on users of NFS repos when repacking is done on the