Re: [PATCH v2] rebase -x: sanity check command

2019-02-13 Thread Ævar Arnfjörð Bjarmason
On Tue, Jan 29 2019, Phillip Wood wrote: > From: Phillip Wood > > If the user gives an empty argument to --exec then git creates a todo > list that it cannot parse. The rebase starts to run before erroring out > with > > error: missing arguments for exec > error: invalid line 2: exec > Yo

Re: [PATCH v2] rebase -x: sanity check command

2019-01-30 Thread Johannes Schindelin
Hi Phillip, On Tue, 29 Jan 2019, Phillip Wood wrote: > Range-diff against v1: > 1: 9626549aec ! 1: 726b84c300 rebase -x: sanity check command > @@ -2,8 +2,9 @@ > > rebase -x: sanity check command > > -If the user gives an empty argument to --exec then the rebase

Re: [PATCH v2] rebase -x: sanity check command

2019-01-29 Thread Junio C Hamano
Phillip Wood writes: > Thanks for the comments. I've updated the code as suggested by Dscho > and tried to make it clearer in the commit message that this is fixing > git creating a todo-list that it cannot parse. Will queue. Thanks.

[PATCH v2] rebase -x: sanity check command

2019-01-29 Thread Phillip Wood
From: Phillip Wood If the user gives an empty argument to --exec then git creates a todo list that it cannot parse. The rebase starts to run before erroring out with error: missing arguments for exec error: invalid line 2: exec You can fix this with 'git rebase --edit-todo' and then run 'g