Re: [PATCH v2] read_directory: avoid invoking exclude machinery on tracked files

2013-02-17 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > If path_handled is returned, contents goes up. And if check_only is > true, the loop could be broken early. These will not happen when > treat_one_path (and its wrapper treat_path) returns > path_ignored. dir_add_name internally does a cache_name_exists() check > s

Re: [PATCH v2] read_directory: avoid invoking exclude machinery on tracked files

2013-02-17 Thread Pete Wyckoff
pclo...@gmail.com wrote on Sun, 17 Feb 2013 11:39 +0700: > On Sun, Feb 17, 2013 at 1:11 AM, Pete Wyckoff wrote: > > pclo...@gmail.com wrote on Sat, 16 Feb 2013 14:17 +0700: > >> Finally some numbers (best of 20 runs) that shows why it's worth all > >> the hassle: > >> > >> git status | webkit li

Re: [PATCH v2] read_directory: avoid invoking exclude machinery on tracked files

2013-02-16 Thread Duy Nguyen
On Sun, Feb 17, 2013 at 1:11 AM, Pete Wyckoff wrote: > pclo...@gmail.com wrote on Sat, 16 Feb 2013 14:17 +0700: >> Finally some numbers (best of 20 runs) that shows why it's worth all >> the hassle: >> >> git status | webkit linux-2.6 libreoffice-core gentoo-x86 >> -+

Re: [PATCH v2] read_directory: avoid invoking exclude machinery on tracked files

2013-02-16 Thread Pete Wyckoff
pclo...@gmail.com wrote on Sat, 16 Feb 2013 14:17 +0700: > Finally some numbers (best of 20 runs) that shows why it's worth all > the hassle: > > git status | webkit linux-2.6 libreoffice-core gentoo-x86 > -+-- > before | 1.097s0.

[PATCH v2] read_directory: avoid invoking exclude machinery on tracked files

2013-02-15 Thread Nguyễn Thái Ngọc Duy
read_directory() (and its friendly wrapper fill_directory) collects untracked/ignored files by traversing through the whole worktree, feeding every entry to treat_one_path(), where each entry is checked against .gitignore patterns. One may see that tracked files can't be excluded and we do not nee