Re: [PATCH v2] log: grep author/committer using mailmap

2012-12-28 Thread Antoine Pelisse
> This is about your rewritten implementation that hasn't escaped to > the general public but sitting in 'next', right? > > Two things that immediately come to mind are: > > - initialization of lowermail can use strbuf_init() instead; > - downcasing can be done in place, i.e. "lowermail.buf[i] =

Re: [PATCH v2] log: grep author/committer using mailmap

2012-12-28 Thread Junio C Hamano
Antoine Pelisse writes: > Actually, gprof seems to be unhappy about the number of call to > strbuf_grow() in map_user() (25% of the time spent in map_user() is > spent in strbuf_grow()). > > That probably comes from the repeated call to strbuf_addch() when > lowering the email address. This is a

Re: [PATCH v2] log: grep author/committer using mailmap

2012-12-28 Thread Antoine Pelisse
Actually, gprof seems to be unhappy about the number of call to strbuf_grow() in map_user() (25% of the time spent in map_user() is spent in strbuf_grow()). That probably comes from the repeated call to strbuf_addch() when lowering the email address. At this point, we are also copying the '\0' for

Re: [PATCH v2] log: grep author/committer using mailmap

2012-12-27 Thread Junio C Hamano
Junio C Hamano writes: > Thanks. I'll queue this on top. > > -- >8 -- > Subject: [PATCH] log --use-mailmap: optimize for cases without > --author/--committer search And this I will *not* queue further on top. -- >8 -- Subject: [PATCH] [DO NOT USE] log --use-mailmap --author/--committer: furth

Re: [PATCH v2] log: grep author/committer using mailmap

2012-12-27 Thread Junio C Hamano
Antoine Pelisse writes: > Currently you can use mailmap to display log authors and committers > but you can't use the mailmap to find commits with mapped values. > > This commit allows you to run: > > git log --use-mailmap --author mapped_name_or_email > git log --use-mailmap --committer

[PATCH v2] log: grep author/committer using mailmap

2012-12-27 Thread Antoine Pelisse
Currently you can use mailmap to display log authors and committers but you can't use the mailmap to find commits with mapped values. This commit allows you to run: git log --use-mailmap --author mapped_name_or_email git log --use-mailmap --committer mapped_name_or_email Of course it onl